Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed tree of elements in property sets #16599

Merged
merged 2 commits into from
Aug 27, 2024
Merged

Fixed tree of elements in property sets #16599

merged 2 commits into from
Aug 27, 2024

Conversation

Ruslan-Aleev
Copy link
Collaborator

What does it do?

Fixed tree of elements in property sets:

  • Fix icons;
  • Fix template name.

ps_before

ps_after

Related issue(s)/PR(s)

N\A

@Ruslan-Aleev Ruslan-Aleev added type-frontend Issues related to UI/UX issues, mostly about styles and frontend implementations on JavaScript. pr/review-needed Pull request requires review and testing. labels Aug 15, 2024
@Ruslan-Aleev Ruslan-Aleev added this to the v3.0.6 milestone Aug 15, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 21.57%. Comparing base (69c7efb) to head (86f3c57).
Report is 9 commits behind head on 3.x.

Files Patch % Lines
...lution/Processors/Element/PropertySet/GetNodes.php 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                3.x   #16599      +/-   ##
============================================
- Coverage     21.57%   21.57%   -0.01%     
- Complexity    10599    10600       +1     
============================================
  Files           561      561              
  Lines         32095    32102       +7     
============================================
- Hits           6926     6925       -1     
- Misses        25169    25177       +8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

theboxer
theboxer approved these changes Aug 21, 2024
View reviewed changes
Copy link
Member

@theboxer theboxer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@Ruslan-Aleev Ruslan-Aleev added pr/ready-for-merging Pull request reviewed and tested and ready for merging. and removed pr/review-needed Pull request requires review and testing. labels Aug 21, 2024
@opengeek opengeek merged commit 2faf7a8 into modxcms:3.x Aug 27, 2024
5 checks passed
@Ruslan-Aleev Ruslan-Aleev deleted the 3.x-property-sets-tree branch August 27, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theboxer theboxer theboxer approved these changes

@Ibochkarev Ibochkarev Ibochkarev approved these changes

@opengeek opengeek Awaiting requested review from opengeek opengeek is a code owner

@Mark-H Mark-H Awaiting requested review from Mark-H Mark-H is a code owner

Assignees
No one assigned
Labels
pr/ready-for-merging Pull request reviewed and tested and ready for merging. type-frontend Issues related to UI/UX issues, mostly about styles and frontend implementations on JavaScript.
Projects
None yet
Milestone
v3.0.6
Development

Successfully merging this pull request may close these issues.
4 participants
@Ruslan-Aleev @theboxer @Ibochkarev @opengeek